Blob Blame History Raw
From c59ff81a78da68eaabc9b2a2a20e2539147fcc61 Mon Sep 17 00:00:00 2001
From: Jakub Filak <jfilak@redhat.com>
Date: Fri, 14 Aug 2015 09:08:22 +0200
Subject: [PATCH] Correct testing of return values from ABRT D-Bus API wrrapper

Related: rhbz#1245262

Signed-off-by: Jakub Filak <jfilak@redhat.com>
---
 src/gnome_abrt/wrappers/problem_details.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/gnome_abrt/wrappers/problem_details.c b/src/gnome_abrt/wrappers/problem_details.c
index deadf0e..1d0bab9 100644
--- a/src/gnome_abrt/wrappers/problem_details.c
+++ b/src/gnome_abrt/wrappers/problem_details.c
@@ -29,8 +29,13 @@ PyObject *p_show_problem_details_for_dir(PyObject *module, PyObject *args)
     PyGObject *pygtkwnd = NULL;
     if (PyArg_ParseTuple(args, "s|O", &dir_str, &pygtkwnd))
     {
-        GtkWindow *wnd = pygtkwnd ? GTK_WINDOW(pygtkwnd->obj) : NULL;
         problem_data_t *problem_data = get_full_problem_data_over_dbus(dir_str);
+
+        /* get_full_problem_data_over_dbus() printed an error message */
+        if (problem_data == ERR_PTR || problem_data == NULL)
+            Py_RETURN_NONE;
+
+        GtkWindow *wnd = pygtkwnd ? GTK_WINDOW(pygtkwnd->obj) : NULL;
         GtkWidget *dialog = problem_details_dialog_new(problem_data, wnd);
 
         if (dialog != NULL)
-- 
2.4.3