|
 |
8be4430 |
From: Sergei Zviagintsev <sergei@s15v.net>
|
|
|
8be4430 |
Date: Wed, 17 Jun 2015 20:14:56 +0300
|
|
|
8be4430 |
Subject: [PATCH] kdbus: kdbus_reply_find(): return on found entry
|
|
|
8be4430 |
|
|
|
8be4430 |
Return found entry immediately instead of assigning it to additional
|
|
|
8be4430 |
variable and breaking the loop. It's simpler to read, the same way is
|
|
|
8be4430 |
used in kdbus_conn_has_name(), for example.
|
|
|
8be4430 |
|
|
|
8be4430 |
Signed-off-by: Sergei Zviagintsev <sergei@s15v.net>
|
|
|
8be4430 |
Reviewed-by: David Herrmann <dh.herrmann@gmail.com>
|
|
|
8be4430 |
Reviewed-by: Djalal Harouni <tixxdz@opendz.org>
|
|
|
8be4430 |
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
|
|
8be4430 |
---
|
|
|
8be4430 |
ipc/kdbus/reply.c | 10 ++++------
|
|
|
8be4430 |
1 file changed, 4 insertions(+), 6 deletions(-)
|
|
|
8be4430 |
|
|
|
8be4430 |
diff --git a/ipc/kdbus/reply.c b/ipc/kdbus/reply.c
|
|
|
8be4430 |
index 89d355b44f63..9d823ebee71f 100644
|
|
|
8be4430 |
--- a/ipc/kdbus/reply.c
|
|
|
8be4430 |
+++ b/ipc/kdbus/reply.c
|
|
|
8be4430 |
@@ -171,17 +171,15 @@ struct kdbus_reply *kdbus_reply_find(struct kdbus_conn *replying,
|
|
|
8be4430 |
struct kdbus_conn *reply_dst,
|
|
|
8be4430 |
u64 cookie)
|
|
|
8be4430 |
{
|
|
|
8be4430 |
- struct kdbus_reply *r, *reply = NULL;
|
|
|
8be4430 |
+ struct kdbus_reply *r;
|
|
|
8be4430 |
|
|
|
8be4430 |
list_for_each_entry(r, &reply_dst->reply_list, entry) {
|
|
|
8be4430 |
if (r->cookie == cookie &&
|
|
|
8be4430 |
- (!replying || r->reply_src == replying)) {
|
|
|
8be4430 |
- reply = r;
|
|
|
8be4430 |
- break;
|
|
|
8be4430 |
- }
|
|
|
8be4430 |
+ (!replying || r->reply_src == replying))
|
|
|
8be4430 |
+ return r;
|
|
|
8be4430 |
}
|
|
|
8be4430 |
|
|
|
8be4430 |
- return reply;
|
|
|
8be4430 |
+ return NULL;
|
|
|
8be4430 |
}
|
|
|
8be4430 |
|
|
|
8be4430 |
/**
|