Why do you need to exclude the docs when building flatpaks? I don't think it's going to make any difference because libsoup is part of the flatpak runtime (which means it's reused from the regular flatpak=0 build and never rebuilt with flatpak=1). I'd rather just leave the flatpak conditionals out.

Also, could you please use a fork when pushing wip branches? It's very difficult to get a private branch removed from regular dist-git once you are done with it.

Otherwise looks fine to me :)

I think that this might not be the right solution (so I would rather hold it) - please take a look at https://bugzilla.redhat.com/show_bug.cgi?id=1915780 (sorry for RH internal link), but there might be something wrong with gtk-doc.

I'd rather just leave the flatpak conditionals out.

Okay, that was a "copy&paste" for the evolution-data-server. I'll drop the flatpak mention there.

Also, could you please use a fork when pushing wip branches?

Hmm, I'm currently "used to" the GNOME GitLab, where is a "delete branch" check and which doesn't work on forks (or maybe it does, I do not know). I'll try to not forget a different workflow here (though I do not propose many patches here, thus I'd probably forget of it soon).

I think that this might not be the right solution...

I see, thanks for the notice and the link. It still can benefit in the split, by not duplicating the files in the -devel packages for each architecture. As I said above, the -doc subpackage is the way Fedora uses for the noarch developer documentation, which is another "benefit" of this change.

If gtk-doc had been fixed, then you might be right that the change is useless now.

I'll update the branch anyway, the maintainer can decide which path to go afterwards. It can be eventually used some time later, in the (distant) future.

Hrm, I'd merge the two commits into one, but I cannot use git push --atomic --force-with-lease here (works on the GNOME GitLab with no problem), I'm getting:

remote: Forced pushes are not allowed
remote: Denied push for ref 'refs/heads/wip/mcrha/doc-subpackage' for user 'mcrha'
remote: All changes have been rejected

I do not see how to reassign this pull request to a different branch (my fork), but I do not want to close this merge request just to replace it with another, because it contains important information.

If approved, I'd commit manually and just close this merge request. Let me know.

Looks good to me. Go for it!

Thanks. Pushed as commit https://src.fedoraproject.org/rpms/libsoup/c/f652009d9f97b6c45df5571fa7a155f88d3d2f1e?branch=master

It's very difficult to get a private branch removed from regular dist-git once you are done with it.

Hrm, I've not been aware of this. You are right, I cannot delete it:

$ git push --delete origin wip/mcrha/doc-subpackage
remote: Branch deletion is not allowed
remote: Denied push for ref 'refs/heads/wip/mcrha/doc-subpackage' for user 'mcrha'
remote: All changes have been rejected
To ssh://pkgs.fedoraproject.org/rpms/libsoup
 ! [remote rejected] wip/mcrha/doc-subpackage (pre-receive hook declined)
error: failed to push some refs to 'ssh://mcrha@pkgs.fedoraproject.org/rpms/libsoup'

What is the procedure to get rid of it, please? May I send an email to Fedora infrastructure list or any other, requesting a delete? Or open a bug against certain component?

I believe you would have to open a releng ticket to get branches removed. I am not sure what the current policy is; it could be that they only remove branches that are fully merged into master.

Oh, I see. I'll figure it out. Thanks.