Blob Blame History Raw
From f10e917b252a809daf9f7650011f68edc6be81b0 Mon Sep 17 00:00:00 2001
From: Evgeny Stambulchik <fnevgeny@gmail.com>
Date: Sun, 4 Aug 2019 00:50:34 +0300
Subject: [PATCH] Make constructors of abstract classes protected

This should fix #445.
---
 src/classes/action/action_mapping.vala | 2 +-
 src/classes/drawings/storage.vala      | 2 +-
 src/classes/renderer/cache/base.vala   | 2 +-
 src/classes/timer_label.vala           | 2 +-
 src/classes/view/behaviour/base.vala   | 2 +-
 5 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/classes/action/action_mapping.vala b/src/classes/action/action_mapping.vala
index 780f80a..0abc307 100644
--- a/src/classes/action/action_mapping.vala
+++ b/src/classes/action/action_mapping.vala
@@ -48,7 +48,7 @@ namespace pdfpc {
          * methods, and we need blank objects to call them.  Thus, this blank
          * constructor.
          */
-        public ActionMapping() {
+        protected ActionMapping() {
             base();
         }
 
diff --git a/src/classes/drawings/storage.vala b/src/classes/drawings/storage.vala
index 6c6e7f9..e5ceaa9 100644
--- a/src/classes/drawings/storage.vala
+++ b/src/classes/drawings/storage.vala
@@ -35,7 +35,7 @@ namespace pdfpc.Drawings.Storage {
          */
         protected Metadata.Pdf metadata;
 
-        public Base(Metadata.Pdf metadata) {
+        protected Base(Metadata.Pdf metadata) {
             this.metadata = metadata;
         }
 
diff --git a/src/classes/renderer/cache/base.vala b/src/classes/renderer/cache/base.vala
index d60730e..2dc39ac 100644
--- a/src/classes/renderer/cache/base.vala
+++ b/src/classes/renderer/cache/base.vala
@@ -37,7 +37,7 @@ namespace pdfpc.Renderer.Cache {
         /**
          * Initialize the cache store
          */
-        public Base(Metadata.Pdf metadata) {
+        protected Base(Metadata.Pdf metadata) {
             this.metadata = metadata;
         }
 
diff --git a/src/classes/timer_label.vala b/src/classes/timer_label.vala
index 8b55acc..8d689e1 100644
--- a/src/classes/timer_label.vala
+++ b/src/classes/timer_label.vala
@@ -95,7 +95,7 @@ namespace pdfpc {
          * Default constructor taking the initial time as argument, as well as
          * the time to countdown until the talk actually starts.
          */
-        public TimerLabel(PresentationController controller, time_t start_time = 0) {
+        protected TimerLabel(PresentationController controller, time_t start_time = 0) {
             this.controller = controller;
             this.start_time = start_time;
         }
diff --git a/src/classes/view/behaviour/base.vala b/src/classes/view/behaviour/base.vala
index 4382ba6..46c8808 100644
--- a/src/classes/view/behaviour/base.vala
+++ b/src/classes/view/behaviour/base.vala
@@ -41,7 +41,7 @@ namespace pdfpc.View {
         /**
          * Base constructor not taking any arguments
          */
-        public Base() {
+        protected Base() {
             // Nothing to do here
         }