59371eb
diff -up ./NEWS.ori ./NEWS
59371eb
--- ./NEWS.ori	2022-08-15 11:59:35.929714848 +0200
59371eb
+++ ./NEWS	2022-08-15 12:00:12.892937479 +0200
59371eb
@@ -1,4 +1,14 @@
59371eb
 procps-ng-NEXT
59371eb
+<<<<<<< HEAD
59371eb
+=======
59371eb
+  * library
59371eb
+    Re-add elogind support                                 merge #151
59371eb
+  * ps: threads again display when -L is used with -q      issue #234
59371eb
+  * ps: proper aix format string behavior was restored
59371eb
+  * sysctl: print dotted keys again
59371eb
+
59371eb
+procps-ng-4.0.0
59371eb
+>>>>>>> b159c198 (sysctl: print dotted keys again)
59371eb
 ---------------
59371eb
   * Rename pwait to pidwait
59371eb
 
59371eb
diff -up ./sysctl.c.ori ./sysctl.c
59371eb
--- ./sysctl.c.ori	2022-08-15 11:59:35.934714878 +0200
59371eb
+++ ./sysctl.c	2022-08-15 12:00:12.893937485 +0200
59371eb
@@ -152,7 +152,7 @@ static SysctlSetting *setting_new(
59371eb
         strcat(path + proc_len, key+1);
59371eb
     else
59371eb
         strcat(path + proc_len, key);
59371eb
-    /* change . to / */
59371eb
+    /* change . to / for path */
59371eb
     slashdot(path + proc_len, '.', '/');
59371eb
 
59371eb
     s = xmalloc(sizeof(SysctlSetting));
59371eb
@@ -510,7 +510,8 @@ static int WriteSetting(
59371eb
 
59371eb
     int rc = EXIT_SUCCESS;
59371eb
     FILE *fp;
59371eb
-	struct stat ts;
59371eb
+    struct stat ts;
59371eb
+    char *dotted_key;
59371eb
 
59371eb
     if (!key || !path)
59371eb
         return rc;
59371eb
@@ -523,13 +524,22 @@ static int WriteSetting(
59371eb
         return rc;
59371eb
 	}
59371eb
 
59371eb
-	if ((ts.st_mode & S_IWUSR) == 0) {
59371eb
-		xwarn(_("setting key \"%s\""), key);
59371eb
+    /* Convert the globbed path into a dotted key */
59371eb
+    if ( (dotted_key = strdup(path + strlen(PROC_PATH))) == NULL) {
59371eb
+	xerrx(EXIT_FAILURE, _("strdup key"));
59371eb
+	return EXIT_FAILURE;
59371eb
+    }
59371eb
+    slashdot(dotted_key, '/', '.');
59371eb
+
59371eb
+    if ((ts.st_mode & S_IWUSR) == 0) {
59371eb
+        xwarn(_("setting key \"%s\""), dotted_key);
59371eb
+	free(dotted_key);
59371eb
         return rc;
59371eb
 	}
59371eb
 
59371eb
-	if (S_ISDIR(ts.st_mode)) {
59371eb
-		xwarn(_("setting key \"%s\""), key);
59371eb
+    if (S_ISDIR(ts.st_mode)) {
59371eb
+        xwarn(_("setting key \"%s\""), dotted_key);
59371eb
+	free(dotted_key);
59371eb
         return rc;
59371eb
 	}
59371eb
 
59371eb
@@ -539,7 +549,7 @@ static int WriteSetting(
59371eb
             case ENOENT:
59371eb
                 if (!IgnoreError) {
59371eb
                     xwarnx(_("\"%s\" is an unknown key%s"),
59371eb
-                           key, (ignore_failure?_(", ignoring"):""));
59371eb
+                           dotted_key, (ignore_failure?_(", ignoring"):""));
59371eb
 				if (!ignore_failure)
59371eb
 				    rc = EXIT_FAILURE;
59371eb
 			}
59371eb
@@ -548,11 +558,11 @@ static int WriteSetting(
59371eb
             case EROFS:
59371eb
             case EACCES:
59371eb
                 xwarnx(_("permission denied on key \"%s\"%s"),
59371eb
-                       key, (ignore_failure?_(", ignoring"):""));
59371eb
+                       dotted_key, (ignore_failure?_(", ignoring"):""));
59371eb
                 break;
59371eb
             default:
59371eb
                 xwarn(_("setting key \"%s\"%s"),
59371eb
-                      key, (ignore_failure?_(", ignoring"):""));
59371eb
+                      dotted_key, (ignore_failure?_(", ignoring"):""));
59371eb
                 break;
59371eb
             }
59371eb
             if (!ignore_failure && errno != ENOENT)
59371eb
@@ -561,7 +571,7 @@ static int WriteSetting(
59371eb
 	    if (0 < fprintf(fp, "%s\n", value))
59371eb
 		rc = EXIT_SUCCESS;
59371eb
             if (close_stream(fp) != 0) {
59371eb
-                xwarn(_("setting key \"%s\""), path);
59371eb
+                xwarn(_("setting key \"%s\""), dotted_key);
59371eb
                 return rc;
59371eb
             }
59371eb
         }
59371eb
@@ -571,7 +581,7 @@ static int WriteSetting(
59371eb
             printf("%s\n", value);
59371eb
         } else {
59371eb
             if (PrintName) {
59371eb
-                printf("%s = %s\n", path, value);
59371eb
+                printf("%s = %s\n", dotted_key, value);
59371eb
             } else {
59371eb
                 if (PrintNewline)
59371eb
                     printf("%s\n", value);
59371eb
@@ -580,6 +590,7 @@ static int WriteSetting(
59371eb
             }
59371eb
         }
59371eb
     }
59371eb
+    free(dotted_key);
59371eb
     return rc;
59371eb
 }
59371eb
 
59371eb
diff -up ./testsuite/sysctl_slash_test.conf.ori ./testsuite/sysctl_slash_test.conf
59371eb
--- ./testsuite/sysctl_slash_test.conf.ori	2022-08-15 12:00:12.894937491 +0200
59371eb
+++ ./testsuite/sysctl_slash_test.conf	2022-08-15 12:00:12.893937485 +0200
59371eb
@@ -0,0 +1 @@
59371eb
+kernel/hostname = procps-test
59371eb
diff -up ./testsuite/sysctl.test/sysctl_write.exp.ori ./testsuite/sysctl.test/sysctl_write.exp
59371eb
--- ./testsuite/sysctl.test/sysctl_write.exp.ori	2022-08-15 11:59:35.934714878 +0200
59371eb
+++ ./testsuite/sysctl.test/sysctl_write.exp	2022-08-15 12:00:12.893937485 +0200
59371eb
@@ -3,11 +3,19 @@ set sysctl ${topdir}sysctl
59371eb
 
59371eb
 set test "sysctl write from command line"
59371eb
 spawn $sysctl --dry-run kernel.hostname=procps-test
59371eb
-expect_pass "$test" "/proc/sys/kernel/hostname = procps-test"
59371eb
+expect_pass "$test" "kernel.hostname = procps-test"
59371eb
+
59371eb
+set test "sysctl write from command line using slash"
59371eb
+spawn $sysctl --dry-run kernel/hostname=procps-test
59371eb
+expect_pass "$test" "kernel.hostname = procps-test"
59371eb
 
59371eb
 set test "sysctl write from configuration file"
59371eb
 spawn $sysctl --dry-run -f ${topdir}testsuite/sysctl_glob_test.conf
59371eb
-expect_pass "$test" "/proc/sys/fs/protected_fifos = 2\\s+/proc/sys/fs/protected_symlinks = 2\\s+/proc/sys/fs/protected_hardlinks = 1"
59371eb
+expect_pass "$test" "fs.protected_fifos = 2\\s+fs.protected_symlinks = 2\\s+fs.protected_hardlinks = 1"
59371eb
+
59371eb
+set test "sysctl write from file with slashes"
59371eb
+spawn $sysctl --dry-run -f ${topdir}testsuite/sysctl_slash_test.conf
59371eb
+expect_pass "$test" "kernel.hostname = procps-test"
59371eb
 
59371eb
 set hostname_file "/proc/sys/kernel/hostname"
59371eb
 if {[file exists ${hostname_file}]} {
59371eb
@@ -25,5 +33,5 @@ if {[file exists ${hostname_file}]} {
59371eb
     expect_spawn_retval "$test" 0
59371eb
   }
59371eb
 } else {
59371eb
-  unsupported "sysctl write: hostname file doe not exist"
59371eb
+  unsupported "sysctl write: hostname file does not exist"
59371eb
 }