Blob Blame History Raw
From 560839d51e54943890c2d37c0d0854792479cb80 Mon Sep 17 00:00:00 2001
From: Kovid Goyal <kovid@kovidgoyal.net>
Date: Tue, 24 May 2022 18:09:16 +0530
Subject: [PATCH 3/3] Change test to not rely on order of cookie iteration

python 3.11 iterates in add order, earlier pythons iterate in domain
sorted order

Fix #74
---
 test/test_cookies.py | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/test/test_cookies.py b/test/test_cookies.py
index 20055d8..ec0c2ff 100644
--- a/test/test_cookies.py
+++ b/test/test_cookies.py
@@ -1022,13 +1022,12 @@ class CookieTests(unittest.TestCase):
             "www.acme.com"
         ]
         paths = ["/", "/", "/", "/blah", "/blah/"]
-
+        expected = set(zip(versions, names, domains, paths))
         # sequential iteration
-        for i in range(4):
-            for c, expected in zip(cs, zip(versions, names, domains, paths)):
-                # assert isinstance(c, Cookie)
-                self.assertEqual((c.version, c.name, c.domain, c.path), expected)
-
+        # python 3.11 iterates in add order, earlier pythons iterate in domain
+        # sorted order
+        actual = {(c.version, c.name, c.domain, c.path) for c in cs}
+        self.assertEqual(expected, actual)
         self.assertRaises(IndexError, lambda cs=cs: cs[5])
 
     def test_parse_ns_headers(self):
-- 
2.37.0.rc1